Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316906: Clarify TLABWasteTargetPercent flag #2236

Closed
wants to merge 2 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Oct 30, 2023

I backport this for parity with 11.0.22-oracle.
Due to JDK-8258459, the code was moved, so the backport is to origin gc_globals.hpp


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316906 needs maintainer approval

Issue

  • JDK-8316906: Clarify TLABWasteTargetPercent flag (Enhancement - P5 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2236/head:pull/2236
$ git checkout pull/2236

Update a local copy of the PR:
$ git checkout pull/2236
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2236

View PR using the GUI difftool:
$ git pr show -t 2236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2236.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@luchenlin luchenlin changed the title Andrew lu backport 8316906 Backport 77fac0f4c6692bcc06456d03a4329d9f8ddeeded Oct 30, 2023
@openjdk openjdk bot changed the title Backport 77fac0f4c6692bcc06456d03a4329d9f8ddeeded 8316906: Clarify TLABWasteTargetPercent flag Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 30, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316906: Clarify TLABWasteTargetPercent flag

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • de9ae1e: 8293811: Provide a reason for PassFailJFrame.forceFail
  • 32e63eb: 8312065: Socket.connect does not timeout when profiling
  • 2fbb4b9: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 910e2c4: 8308910: Allow executeAndLog to accept running process
  • 46ce8cb: 8306765: Some client related jtreg problem list entries are malformed
  • 9f74d26: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
  • 53acd95: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • dd1994e: 8231931: [TESTBUG] serviceability/sa/TestUniverse.java looks for wrong string with Shenandoah
  • cf13e82: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • b9936cd: 8221396: Clean up serviceability/sa/TestUniverse.java
  • ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/c12421376a1d4945b48ab4c6d8dc2e83246d1889...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 2, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@luchenlin
Your change (at version 369118c) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 6, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

Going to push as commit feb051f.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 9abfdde: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 18d616d: 8306280: Open source several choice AWT tests
  • f993ef5: 8284331: Add sanity check for signal handler modification warning.
  • 92c5062: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • d90b9ac: 8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
  • 3377127: 8183374: Refactor java/lang/Runtime shell tests to java
  • c73323b: 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file
  • 569ecf4: 8226825: Replace wildcard address with loopback or local host in tests - part 19
  • ef475f7: 8224204: Replace wildcard address with loopback or local host in tests - part 10
  • 4ebccd6: 8223145: Replace wildcard address with loopback or local host in tests - part 1
  • ... and 22 more: https://git.openjdk.org/jdk11u-dev/compare/c12421376a1d4945b48ab4c6d8dc2e83246d1889...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2023
@openjdk openjdk bot closed this Nov 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@GoeLin @luchenlin Pushed as commit feb051f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants