New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java #2251
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Pretty large change for the fact that the title suggests it's just about deleting six characters.
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ff19eeb.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.22-oracle.
Adapted the syntax of the """ string literal.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2251/head:pull/2251
$ git checkout pull/2251
Update a local copy of the PR:
$ git checkout pull/2251
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2251/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2251
View PR using the GUI difftool:
$ git pr show -t 2251
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2251.diff
Webrev
Link to Webrev Comment