Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8185531: [TESTBUG] Improve test configuration for shared strings #2260

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Nov 6, 2023

Hi all,

This pull request contains a backport of commit 8a5467b9 from the openjdk/jdk repository.

The commit being backported was authored by Mikhailo Seledtsov on 2 Aug 2018 and was reviewed by Ioi Lam and Gerard Ziemski.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8185531 needs maintainer approval

Issue

  • JDK-8185531: [TESTBUG] Improve test configuration for shared strings (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2260/head:pull/2260
$ git checkout pull/2260

Update a local copy of the PR:
$ git checkout pull/2260
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2260

View PR using the GUI difftool:
$ git pr show -t 2260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2260.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8a5467b9c22f80a22aa12d45694e8432e6c6e47d 8185531: [TESTBUG] Improve test configuration for shared strings Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 7, 2023
@GoeLin
Copy link
Member

GoeLin commented Nov 8, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@GoeLin
8185531: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8185531: [TESTBUG] Improve test configuration for shared strings

Added extra test configurations to the tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 34cc089: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • b773f56: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
  • 799a7c8: 8292683: Remove BadKeyUsageTest.java from Problem List
  • 0bc8b22: 8230858: Replace wildcard address with loopback or local host in tests - part 23
  • 3592b70: 8317373: Add Telia Root CA v2
  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 5754eb1: 8290469: Add new positioning options to PassFailJFrame test framework
  • 2aca53f: 8026393: jarsigner never shows a warning in badKeyUsage case
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/b64a1acb212a64629094bf7e992d98500f91d629...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 8, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@SoniaZaldana
Your change (at version 85ab8e9) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 9, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

Going to push as commit 2bbab16.
Since your change was applied there have been 15 commits pushed to the master branch:

  • c54521b: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
  • 416c48e: 8310265: (process) jspawnhelper should not use argv[0]
  • 34cc089: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • b773f56: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
  • 799a7c8: 8292683: Remove BadKeyUsageTest.java from Problem List
  • 0bc8b22: 8230858: Replace wildcard address with loopback or local host in tests - part 23
  • 3592b70: 8317373: Add Telia Root CA v2
  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/b64a1acb212a64629094bf7e992d98500f91d629...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2023
@openjdk openjdk bot closed this Nov 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@GoeLin @SoniaZaldana Pushed as commit 2bbab16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants