New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8185531: [TESTBUG] Improve test configuration for shared strings #2260
8185531: [TESTBUG] Improve test configuration for shared strings #2260
Conversation
👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
|
/approve yes |
@GoeLin |
@SoniaZaldana This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@SoniaZaldana |
/sponsor |
Going to push as commit 2bbab16.
Your commit was automatically rebased without conflicts. |
@GoeLin @SoniaZaldana Pushed as commit 2bbab16. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 8a5467b9 from the openjdk/jdk repository.
The commit being backported was authored by Mikhailo Seledtsov on 2 Aug 2018 and was reviewed by Ioi Lam and Gerard Ziemski.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2260/head:pull/2260
$ git checkout pull/2260
Update a local copy of the PR:
$ git checkout pull/2260
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2260/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2260
View PR using the GUI difftool:
$ git pr show -t 2260
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2260.diff
Webrev
Link to Webrev Comment