Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301310: The SendRawSysexMessage test may cause a JVM crash #2279

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 14, 2023

Hi all,

This pull request contains a backport of commit d725b73d from the openjdk/jdk repository.

The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • JDK-8301310 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301310: The SendRawSysexMessage test may cause a JVM crash (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2279/head:pull/2279
$ git checkout pull/2279

Update a local copy of the PR:
$ git checkout pull/2279
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2279

View PR using the GUI difftool:
$ git pr show -t 2279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2279.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d725b73df01ae4478dfaabc47c48cd7231d91afa 8301310: The SendRawSysexMessage test may cause a JVM crash Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review November 15, 2023 05:06
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301310: The SendRawSysexMessage test may cause a JVM crash

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • 3b2d165: 8186610: move ModuleUtils to top-level testlibrary
  • 1080258: 8218754: JDK-8068225 regression in JDIBreakpointTest
  • 04d2033: 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java
  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java
  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • ... and 40 more: https://git.openjdk.org/jdk11u-dev/compare/5a7b227193a4b71697675611031781156ae30f72...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 6, 2023
@mrserb
Copy link
Member Author

mrserb commented Dec 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2023

Going to push as commit af09671.
Since your change was applied there have been 62 commits pushed to the master branch:

  • 325a93f: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
  • ed2dbac: 8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out
  • e63499d: 8217475: Unexpected StackOverflowError in "process reaper" thread
  • 3ea286a: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 31064b1: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM
  • 8a390c8: 8281717: Cover logout method for several LoginModule
  • a9536ae: 8226905: unproblem list applications/ctw/modules/* tests on windows
  • c77e538: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 050bbdb: 8225471: Test utility jdk.test.lib.util.FileUtils.areAllMountPointsAccessible needs to tolerate duplicates
  • c0575b8: 8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written."
  • ... and 52 more: https://git.openjdk.org/jdk11u-dev/compare/5a7b227193a4b71697675611031781156ae30f72...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2023
@openjdk openjdk bot closed this Dec 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@mrserb Pushed as commit af09671.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant