8317374: Add Let's Encrypt ISRG Root X2

[jerboaa]

Unclean backport, but got resolved trivially. Pattern matching for switch isn't present in 11u. Test change in VerifyCACerts.java has slightly different context. Fixed those issues manually. Please review!

Testing:

• GHA
• test/jdk/sun/security/lib/cacerts and test/jdk/security/infra/java/security/cert/CertPathValidator tests. All pass (including the new one CAInterop.java#letsencryptisrgx2

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317374 needs maintainer approval

Issue

• JDK-8317374: Add Let's Encrypt ISRG Root X2 (Enhancement - P2 - Approved)

Reviewers

• Goetz Lindenmaier (@GoeLin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2280/head:pull/2280
$ git checkout pull/2280

Update a local copy of the PR:
$ git checkout pull/2280
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2280

View PR using the GUI difftool:
$ git pr show -t 2280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2280.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9b8baca5)

[jerboaa]

Anyone willing to review this, please? Thanks!

[GoeLin]

LGTM

Hint: if you base this on the 17u commit, only the CAInterop change remains.
The other two changes, adapting the path and the hash, are identical.
You can use "Backport <17u hash>.
It's a bummer we always have to resolve the switch syntax.

[openjdk]

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8317374: Add Let's Encrypt ISRG Root X2

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 7814102: 8244508: JFR: FlightRecorderOptions reset date format
• 10ddd51: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
• 45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
• 046b213: 8268916: Tests for AffirmTrust roots

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

/integrate

[openjdk]

Going to push as commit f2488a3.
Since your change was applied there have been 4 commits pushed to the master branch:

• 7814102: 8244508: JFR: FlightRecorderOptions reset date format
• 10ddd51: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
• 45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
• 046b213: 8268916: Tests for AffirmTrust roots

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit f2488a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jerboaa]

Hint: if you base this on the 17u commit, only the CAInterop change remains.
The other two changes, adapting the path and the hash, are identical.

I believe I did that. The context for 11u was still different enough for it to not apply cleanly.

You can use "Backport <17u hash>.

In the PR?

It's a bummer we always have to resolve the switch syntax.

Yeah.

[GoeLin]

In the PR?
As title of the PR, or as title of the change you push for your PR.
You can also use the /backport command in any commit, but this won't help here as it's not clean.