Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry #2300

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 27, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8227438 needs maintainer approval

Issue

  • JDK-8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2300/head:pull/2300
$ git checkout pull/2300

Update a local copy of the PR:
$ git checkout pull/2300
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2300

View PR using the GUI difftool:
$ git pr show -t 2300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2300.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2169215b298707d5e160bed81a2aa3c6ba814a18 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 28, 2023
@GoeLin
Copy link
Member

GoeLin commented Nov 29, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@GoeLin
8227438: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 0e29291: 8320884: Bump update version for OpenJDK: jdk-11.0.23
  • be01e6e: 8263530: sun.awt.X11.ListHelper.removeAll() should use clear()
  • 40ee106: 8282143: Objects.requireNonNull should be ForceInline
  • a3661a5: 8231556: Wrong font ligatures used when 2 versions of same font used
  • f65058e: 8053479: (dc) DatagramChannel.read() throws exception instead of discarding data when buffer too small
  • a956ba6: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 911c359: 8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException
  • bd7420a: 8224035: Replace wildcard address with loopback or local host in tests - part 9
  • f9bedac: 8218178: vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java fails with -Xcomp
  • 345122d: 8067250: [mlvm] vm/mlvm/mixed/stress/regression/b6969574 fails and perf regression
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/a72d0b2894a2fa26eb521c3ceb21a86b2f517bb3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 29, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@luchenlin
Your change (at version c6e2bf6) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 29, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

Going to push as commit 3a3efef.
Since your change was applied there have been 16 commits pushed to the master branch:

  • cf544e0: 8214915: CtwRunner misses export for jdk.internal.access
  • 9d4da7c: 8214908: add ctw tests for jdk.jfr and jdk.management.jfr modules
  • 9591e12: 8219475: javap man page needs to be updated
  • 0e29291: 8320884: Bump update version for OpenJDK: jdk-11.0.23
  • be01e6e: 8263530: sun.awt.X11.ListHelper.removeAll() should use clear()
  • 40ee106: 8282143: Objects.requireNonNull should be ForceInline
  • a3661a5: 8231556: Wrong font ligatures used when 2 versions of same font used
  • f65058e: 8053479: (dc) DatagramChannel.read() throws exception instead of discarding data when buffer too small
  • a956ba6: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 911c359: 8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException
  • ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/a72d0b2894a2fa26eb521c3ceb21a86b2f517bb3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 29, 2023
@openjdk openjdk bot closed this Nov 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@GoeLin @luchenlin Pushed as commit 3a3efef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants