Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java #2306

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Nov 29, 2023

Backport of JDK-8226706


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8226706 needs maintainer approval

Issue

  • JDK-8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2306/head:pull/2306
$ git checkout pull/2306

Update a local copy of the PR:
$ git checkout pull/2306
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2306

View PR using the GUI difftool:
$ git pr show -t 2306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2306.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4d1ff6a295539e1654c69eb88657af6e59603402 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Nov 30, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Clean backort. SAP nightlies passed on 2023-11-30.”

1 similar comment
@amosshi
Copy link
Contributor Author

amosshi commented Nov 30, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Clean backort. SAP nightlies passed on 2023-11-30.”

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@amosshi
8226706: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@amosshi
8226706: The approval request was already up to date.

@openjdk openjdk bot added the approval label Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • bc48a48: 8311511: Improve description of NativeLibrary JFR event
  • 1df80ba: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 229ddde: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns
  • 360bab8: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
  • 3988054: 8208699: remove unneeded imports from runtime tests
  • 4ddc5d7: 8315606: Open source few swing text/html tests
  • ac1764d: 8289511: Improve test coverage for XPath Axes: child
  • 3a3efef: 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry
  • cf544e0: 8214915: CtwRunner misses export for jdk.internal.access
  • 9d4da7c: 8214908: add ctw tests for jdk.jfr and jdk.management.jfr modules
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 30, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 4, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@amosshi
Your change (at version 01b8d05) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 4, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

Going to push as commit 7dfd132.
Since your change was applied there have been 20 commits pushed to the master branch:

  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 4245e3c: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • 5c92da0: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU
  • b88668b: 8213926: WB_EnqueueInitializerForCompilation requests compilation for NULL
  • 4b88beb: 8213622: Windows VS2013 build failure - "'snprintf': identifier not found"
  • b9b01c9: 8192864: defmeth tests can hide failures
  • ca2290b: 8208705: [TESTBUG] The -Xlog:cds,cds+hashtables vm option is not always required for appcds tests
  • ae6b8d0: 8208704: runtime/appcds/MultiReleaseJars.java timed out often in hs-tier7 testing
  • bc48a48: 8311511: Improve description of NativeLibrary JFR event
  • 1df80ba: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2023
@openjdk openjdk bot closed this Dec 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@GoeLin @amosshi Pushed as commit 7dfd132.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8226706 branch December 6, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants