New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8202282: [TESTBUG] appcds TestCommon.makeCommandLineForAppCDS() can be removed #2313
Conversation
👋 Welcome back ashi! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Unclean backport. SAP nightlies passed on 2023-11-30.” |
/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Unclean backport. SAP nightlies passed on 2023-11-30.” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amosshi,
this looks good to me.
(local test failures of runtime/appcds/sharedStrings/SharedStringsBasic.java
are related to another backport.)
Cheers, Richard.
|
@amosshi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 47 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@reinrich) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 7d85ecf.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8202282
Note.
unclean
backport.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2313/head:pull/2313
$ git checkout pull/2313
Update a local copy of the PR:
$ git checkout pull/2313
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2313/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2313
View PR using the GUI difftool:
$ git pr show -t 2313
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2313.diff
Webrev
Link to Webrev Comment