Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226905: unproblem list applications/ctw/modules/* tests on windows #2333

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 5, 2023

Backport of JDK-8226905

Note the diff file for test/hotspot/jtreg/ProblemList.txt cannot be applied automatically

  • Because in jdk commit the ticket was 8205016
  • While in current jdk11u-dev repo it is JDK-8189604 and JDK-8204842
  • The file test/hotspot/jtreg/ProblemList.txt has been handled manually
  • So this change can be considered as clean

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8226905 needs maintainer approval

Issue

  • JDK-8226905: unproblem list applications/ctw/modules/* tests on windows (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2333/head:pull/2333
$ git checkout pull/2333

Update a local copy of the PR:
$ git checkout pull/2333
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2333

View PR using the GUI difftool:
$ git pr show -t 2333

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2333.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cac96b1b587d3c0203a252cca10bc7aa4530d274 8226905: unproblem list applications/ctw/modules/* tests on windows Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Dec 6, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Clean backort. SAP nightlies passed on 2023-12-05.”

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@amosshi
8226905: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Dec 6, 2023
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8189604 and 8204842 have both been solved and backported.

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@amosshi
Copy link
Contributor Author

amosshi commented Dec 7, 2023

Test

  • Verified the following test cases working on my dev laptop today, OS version Windows 11 Enterprise 22H2
    • test/hotspot/jtreg/applications/ctw/modules/java_desktop.java
    • test/hotspot/jtreg/applications/ctw/modules/java_desktop_2.java
    • test/hotspot/jtreg/applications/ctw/modules/jdk_jconsole.java

@amosshi
Copy link
Contributor Author

amosshi commented Dec 7, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. SAP nightly test passed on 2023-12-05.”

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@amosshi
8226905: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8226905: unproblem list applications/ctw/modules/* tests on windows

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • c77e538: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 050bbdb: 8225471: Test utility jdk.test.lib.util.FileUtils.areAllMountPointsAccessible needs to tolerate duplicates
  • c0575b8: 8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written."
  • 8191f62: 8316030: Update Libpng to 1.6.40
  • db1d944: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • ... and 24 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 7, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 7, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@amosshi
Your change (at version 52c58d4) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 7, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit a9536ae.
Since your change was applied there have been 34 commits pushed to the master branch:

  • c77e538: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 050bbdb: 8225471: Test utility jdk.test.lib.util.FileUtils.areAllMountPointsAccessible needs to tolerate duplicates
  • c0575b8: 8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written."
  • 8191f62: 8316030: Update Libpng to 1.6.40
  • db1d944: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • ... and 24 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@GoeLin @amosshi Pushed as commit a9536ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8226905 branch December 16, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants