Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213927: G1 ignores AlwaysPreTouch when UseTransparentHugePages is enabled #2355

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 12, 2023

Backport of JDK-8213927

  • Clean backport
  • PR Test - All checks have passed
  • SAP nightlies passed on 2023-12-14

Progress

  • Change must not contain extraneous whitespace
  • JDK-8213927 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8213927: G1 ignores AlwaysPreTouch when UseTransparentHugePages is enabled (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2355/head:pull/2355
$ git checkout pull/2355

Update a local copy of the PR:
$ git checkout pull/2355
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2355

View PR using the GUI difftool:
$ git pr show -t 2355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2355.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fc8795984a9dfb9054663cef78848135f05ba011 8213927: G1 ignores AlwaysPreTouch when UseTransparentHugePages is enabled Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Dec 14, 2023

/approval request “Backporting for parity with jdk 11.0.23-oracle. Clean backort. SAP nightlies passed on 2023-12-14”

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@amosshi
8213927: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213927: G1 ignores AlwaysPreTouch when UseTransparentHugePages is enabled

With UseTransparentHugePages we always need to pretouch on small page size as the underlying memory could currently be allocated as either small or large pages.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 9ad2741: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
  • 1a3385e: 8302017: Allocate BadPaddingException only if it will be thrown
  • aa03b6f: 8211438: [Testbug] runtime/XCheckJniJsig/XCheckJSig.java looks for libjsig in wrong location
  • 3a961da: 8209946: [TESTBUG] CDS tests should use "@run driver"
  • dec947a: 8209549: remove VMPropsExt from TEST.ROOT
  • 1adabcd: 8307683: Loop Predication should not hoist range checks with trap on success projection by negating their condition
  • b3d7b57: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • ccc74bb: 8208623: [TESTBUG] runtime/LoadClass/LongBCP.java fails in AUFS file system
  • 7d85ecf: 8202282: [TESTBUG] appcds TestCommon.makeCommandLineForAppCDS() can be removed
  • 7833ea8: 8219585: [TESTBUG] sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java passes trivially when it shouldn't
  • ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 15, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 15, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@amosshi
Your change (at version b05ac36) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@GoeLin Only the author (@amosshi) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@GoeLin
Copy link
Member

GoeLin commented Dec 15, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

Going to push as commit 4543378.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 0c9de02: 8211978: Move testlibrary/jdk/testlibrary/SimpleSSLContext.java and testkeys to network testlibrary
  • 9ad2741: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
  • 1a3385e: 8302017: Allocate BadPaddingException only if it will be thrown
  • aa03b6f: 8211438: [Testbug] runtime/XCheckJniJsig/XCheckJSig.java looks for libjsig in wrong location
  • 3a961da: 8209946: [TESTBUG] CDS tests should use "@run driver"
  • dec947a: 8209549: remove VMPropsExt from TEST.ROOT
  • 1adabcd: 8307683: Loop Predication should not hoist range checks with trap on success projection by negating their condition
  • b3d7b57: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • ccc74bb: 8208623: [TESTBUG] runtime/LoadClass/LongBCP.java fails in AUFS file system
  • 7d85ecf: 8202282: [TESTBUG] appcds TestCommon.makeCommandLineForAppCDS() can be removed
  • ... and 27 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2023
@openjdk openjdk bot closed this Dec 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@GoeLin @amosshi Pushed as commit 4543378.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8213927 branch December 16, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants