Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314830: runtime/ErrorHandling/ tests ignore external VM flags #2508

Closed
wants to merge 2 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Feb 6, 2024

I backport this for parity with 11.0.23-oracle.

test/hotspot/jtreg/runtime/ErrorHandling/ClassPathEnvVar.java
test/hotspot/jtreg/runtime/ErrorHandling/ReattemptErrorTest.java
test/hotspot/jtreg/runtime/ErrorHandling/ResourceMarkTest.java
test/hotspot/jtreg/runtime/ErrorHandling/TestAbortVmOnException.java
test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java
test/hotspot/jtreg/runtime/ErrorHandling/ClassPathEnvVar.java
test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileOverwriteTest.java
test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java
test/hotspot/jtreg/runtime/ErrorHandling/ReattemptErrorTest.java
test/hotspot/jtreg/runtime/ErrorHandling/ResourceMarkTest.java
test/hotspot/jtreg/runtime/ErrorHandling/TestAbortVmOnException.java
test/hotspot/jtreg/runtime/ErrorHandling/TestGZippedHeapDumpOnOutOfMemoryError.java
test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java
these tests are not in 11, skipped, others are clean except Copyright.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314830 needs maintainer approval

Issue

  • JDK-8314830: runtime/ErrorHandling/ tests ignore external VM flags (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2508/head:pull/2508
$ git checkout pull/2508

Update a local copy of the PR:
$ git checkout pull/2508
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2508

View PR using the GUI difftool:
$ git pr show -t 2508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2508.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

i556354 added 2 commits February 6, 2024 16:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b685ee00b273f029aa2ed5015e64cf409b0b0408 8314830: runtime/ErrorHandling/ tests ignore external VM flags Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 6, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 6, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed approval labels Feb 19, 2024
@luchenlin luchenlin closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants