8314830: runtime/ErrorHandling/ tests ignore external VM flags #2508
+30
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this for parity with 11.0.23-oracle.
test/hotspot/jtreg/runtime/ErrorHandling/ClassPathEnvVar.java
test/hotspot/jtreg/runtime/ErrorHandling/ReattemptErrorTest.java
test/hotspot/jtreg/runtime/ErrorHandling/ResourceMarkTest.java
test/hotspot/jtreg/runtime/ErrorHandling/TestAbortVmOnException.java
test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java
test/hotspot/jtreg/runtime/ErrorHandling/ClassPathEnvVar.java
test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileOverwriteTest.java
test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java
test/hotspot/jtreg/runtime/ErrorHandling/ReattemptErrorTest.java
test/hotspot/jtreg/runtime/ErrorHandling/ResourceMarkTest.java
test/hotspot/jtreg/runtime/ErrorHandling/TestAbortVmOnException.java
test/hotspot/jtreg/runtime/ErrorHandling/TestGZippedHeapDumpOnOutOfMemoryError.java
test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java
these tests are not in 11, skipped, others are clean except Copyright.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2508/head:pull/2508
$ git checkout pull/2508
Update a local copy of the PR:
$ git checkout pull/2508
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2508/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2508
View PR using the GUI difftool:
$ git pr show -t 2508
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2508.diff
Webrev
Link to Webrev Comment