Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout #2537

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 21, 2024


Progress

  • JDK-8309305 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2537/head:pull/2537
$ git checkout pull/2537

Update a local copy of the PR:
$ git checkout pull/2537
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2537/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2537

View PR using the GUI difftool:
$ git pr show -t 2537

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2537.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8042a50b99a671390910afa5f816894f77255429 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2024
@sendaoYan
Copy link
Member Author

/approval JDK-8309305 request

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan
JDK-8309305: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 21, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2024

Webrevs

@openjdk openjdk bot removed the approval label Feb 22, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented Mar 6, 2024

JDK-8309305 doesn't affect linux, I need some time to make a windows test environment to verify this backport.

/approval cancel

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@sendaoYan
8309305: The approval request has been cancelled successfully.

@sendaoYan
Copy link
Member Author

sendaoYan commented Mar 6, 2024

Shoule I close this PR first. After I finish verify this backport on windows then reopen this PR?

@sendaoYan sendaoYan closed this Mar 6, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 6, 2024

No, there is no need to close it. But you should not request approval if it is not ready. Maybe you want to make it a draft PR.

@sendaoYan
Copy link
Member Author

No, there is no need to close it. But you should not request approval if it is not ready. Maybe you want to make it a draft PR.

OK.

@sendaoYan sendaoYan reopened this Mar 6, 2024
@sendaoYan sendaoYan marked this pull request as draft March 6, 2024 13:02
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 6, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented Mar 6, 2024

This testcase run pass on windows for now. And this testcase not in Problem-list.txt. I think it's not need to backport JDK-8309305

image

$ uname -a
CYGWIN_NT-6.3-WOW iZck0gair6fxxcZ 3.1.6(0.340/5/3) 2020-07-09 08:16 i686 Cygwin

@sendaoYan sendaoYan closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants