-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found #2817
8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found #2817
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue and summary from the original commit. |
Thanks for the review! |
/approval request Should get backported for parity with 11.0.25-oracle. The backport has been reviewed and tier 1-4 have passed. |
@TheRealMDoerr |
6d1e69a
to
a3f4794
Compare
@TheRealMDoerr Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Rebased after dependent PR is integrated. Still looks sane. |
Going to push as commit 468d6a7. |
@TheRealMDoerr Pushed as commit 468d6a7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8222005 on top of #2816.
constantPoolHandle other_cp
needs to be removed, because it's replaced in new code (2nd commit).Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2817/head:pull/2817
$ git checkout pull/2817
Update a local copy of the PR:
$ git checkout pull/2817
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2817/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2817
View PR using the GUI difftool:
$ git pr show -t 2817
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2817.diff
Webrev
Link to Webrev Comment