Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found #2817

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 26, 2024

Backport of JDK-8222005 on top of #2816.

  1. jvmtiRedefineClasses.cpp requires manual integration, but all hunks are integrated (1st commit).
  2. constantPoolHandle other_cp needs to be removed, because it's replaced in new code (2nd commit).

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8222005 needs maintainer approval

Issue

  • JDK-8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2817/head:pull/2817
$ git checkout pull/2817

Update a local copy of the PR:
$ git checkout pull/2817
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2817

View PR using the GUI difftool:
$ git pr show -t 2817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2817.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/2816 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found

Remove optimizations from class redefinition that cause the guarantee hit

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2ff9f53a442a625316cb6fedd699008d68cebc15 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 11.0.25-oracle. The backport has been reviewed and tier 1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@TheRealMDoerr
8222005: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Jun 27, 2024
@TheRealMDoerr TheRealMDoerr changed the base branch from pr/2816 to master June 28, 2024 09:19
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 28, 2024
@TheRealMDoerr TheRealMDoerr force-pushed the 8222005_ClassRedefinition branch from 6d1e69a to a3f4794 Compare June 28, 2024 09:23
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@TheRealMDoerr Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@TheRealMDoerr
Copy link
Contributor Author

Rebased after dependent PR is integrated. Still looks sane.
/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

Going to push as commit 468d6a7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2024
@openjdk openjdk bot closed this Jun 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@TheRealMDoerr Pushed as commit 468d6a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8222005_ClassRedefinition branch June 28, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants