Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing #3017

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Mar 28, 2025

Clean backport of JDK-8352561 that solves a problem with TimestampCheck.java.

All test/jdk/sun/security tests pass now:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/sun/security                         659   659     0     0   
==============================
TEST SUCCESS

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352302 needs maintainer approval

Issue

  • JDK-8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3017/head:pull/3017
$ git checkout pull/3017

Update a local copy of the PR:
$ git checkout pull/3017
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3017

View PR using the GUI difftool:
$ git pr show -t 3017

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3017.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b2255b98f5122c3d26b822dac4597a54257ffcaf 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2025

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Mar 28, 2025

Duplicate of #3014?

@vieiro
Copy link
Contributor Author

vieiro commented Mar 28, 2025

Duplicate of #3014?

Indeed! Closing…

@vieiro vieiro closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants