-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies #85
8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies #85
Conversation
Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively. Below are the test results: * after_release: **123.62s user 10.26s system 160% cpu 1:23.59 total** * after_fastdebug: **197.42s user 15.07s system 195% cpu 1:48.49 total** * before_release: **123.65s user 9.56s system 159% cpu 1:23.38 total** * before_fastdebug: **232.70s user 15.29s system 170% cpu 2:25.70 total**
👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@roy-soumadipta This change is no longer ready for integration - check the PR body for details. |
/integrate |
@roy-soumadipta |
No, wait, this is not approved for any 11u, so we cannot integrate. |
/reviewers 1 |
Closing this PR due to incorrect repo. Raised backport request in correct repo: openjdk/jdk11u-dev#2150 |
Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively.
Below are the test results:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/85/head:pull/85
$ git checkout pull/85
Update a local copy of the PR:
$ git checkout pull/85
$ git pull https://git.openjdk.org/jdk11u.git pull/85/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 85
View PR using the GUI difftool:
$ git pr show -t 85
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/85.diff
Webrev
Link to Webrev Comment