Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286398: Address possibly lossy conversions in jdk.internal.le #1325

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 5, 2023

I backport this as prerequisite of 8297587: Upgrade JLine to 3.22.0


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286398: Address possibly lossy conversions in jdk.internal.le

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1325/head:pull/1325
$ git checkout pull/1325

Update a local copy of the PR:
$ git checkout pull/1325
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1325

View PR using the GUI difftool:
$ git pr show -t 1325

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1325.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e534c133af9bcefb073a336f1fdc0dc226a9dd82 8286398: Address possibly lossy conversions in jdk.internal.le May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 5, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286398: Address possibly lossy conversions in jdk.internal.le

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 5, 2023
@mlbridge
Copy link

mlbridge bot commented May 5, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented May 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2023

Going to push as commit 05f1562.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 8c54104: 8286191: misc tests fail due to JDK-8285987
  • 7dab7e5: 8285987: executing shell scripts without #! fails on Alpine linux
  • 7251548: 8283057: Update GCC to version 11.2.0 for Oracle builds on Linux
  • 6dbd5a6: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)
  • fc1d3d3: 8304291: [AIX] Broken build after JDK-8301998
  • 31bbf9f: 8306825: Monitor deflation might be accidentally disabled by zero intervals
  • 58c9f6a: 8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2023
@openjdk openjdk bot closed this May 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

@GoeLin Pushed as commit 05f1562.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant