Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs #1345

Closed
wants to merge 1 commit into from

Conversation

yftsai
Copy link
Contributor

@yftsai yftsai commented May 15, 2023

Backport 8c70bf3fff6f01b637f9e72a0b4c617051dbfafd

The following tests have passed.

jtreg:test/hotspot/jtreg/compiler/intrinsics/zip/TestCRC32C.java
jtreg:test/jdk/java/util/zip/TestCRC32C.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1345/head:pull/1345
$ git checkout pull/1345

Update a local copy of the PR:
$ git checkout pull/1345
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1345

View PR using the GUI difftool:
$ git pr show -t 1345

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1345.diff

Webrev

Link to Webrev Comment

…mall inputs

Reviewed-by: kvn, eastigeevich, sviswanathan
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2023

👋 Welcome back yftsai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for s… 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs May 15, 2023
@yftsai yftsai changed the title 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs Backport 8c70bf3fff6f01b637f9e72a0b4c617051dbfafd May 15, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 15, 2023
@openjdk openjdk bot changed the title Backport 8c70bf3fff6f01b637f9e72a0b4c617051dbfafd 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs May 15, 2023
@openjdk
Copy link

openjdk bot commented May 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 15, 2023
@mlbridge
Copy link

mlbridge bot commented May 15, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. Lgtm.

@openjdk
Copy link

openjdk bot commented May 15, 2023

⚠️ @yftsai the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8299544
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented May 15, 2023

@yftsai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • e7bac42: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
  • 093f02a: 8305975: Add TWCA Global Root CA
  • bf7ceda: 8282201: Consider removal of expiry check in VerifyCACerts.java test
  • 398da7e: 8305088: SIGSEGV in Method::is_method_handle_intrinsic
  • 1970b63: 8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed
  • 5b29c6e: 8304867: Explicitly disable dtrace for ppc builds
  • d5a2309: 8297587: Upgrade JLine to 3.22.0
  • 8656141: 8301216: ForkJoinPool invokeAll() ignores timeout
  • 3f52961: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • efa1786: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • ... and 52 more: https://git.openjdk.org/jdk17u-dev/compare/a000b2d6b8fd13e9f7d3e71b8fe06b25fb529923...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2023
@yftsai
Copy link
Contributor Author

yftsai commented May 16, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

@yftsai
Your change (at version 7bd9306) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 16, 2023

Going to push as commit e55bea4.
Since your change was applied there have been 62 commits pushed to the master branch:

  • e7bac42: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
  • 093f02a: 8305975: Add TWCA Global Root CA
  • bf7ceda: 8282201: Consider removal of expiry check in VerifyCACerts.java test
  • 398da7e: 8305088: SIGSEGV in Method::is_method_handle_intrinsic
  • 1970b63: 8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed
  • 5b29c6e: 8304867: Explicitly disable dtrace for ppc builds
  • d5a2309: 8297587: Upgrade JLine to 3.22.0
  • 8656141: 8301216: ForkJoinPool invokeAll() ignores timeout
  • 3f52961: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • efa1786: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • ... and 52 more: https://git.openjdk.org/jdk17u-dev/compare/a000b2d6b8fd13e9f7d3e71b8fe06b25fb529923...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2023
@openjdk openjdk bot closed this May 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

@phohensee @yftsai Pushed as commit e55bea4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants