Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306941: Open source several datatransfer and dnd AWT tests #1355

Closed

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented May 16, 2023

Backport openjdk/jdk@3d3eaed
https://bugs.openjdk.org/browse/JDK-8306941 Open source several datatransfer and dnd AWT tests

Clean backport, new tests, low risk
Checked on macos, linux x64, all passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306941: Open source several datatransfer and dnd AWT tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1355/head:pull/1355
$ git checkout pull/1355

Update a local copy of the PR:
$ git checkout pull/1355
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1355

View PR using the GUI difftool:
$ git pr show -t 1355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1355.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d3eaed9133dbe728ca8e00a626d33f7e35ba9ff 8306941: Open source several datatransfer and dnd AWT tests May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 16, 2023

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306941: Open source several datatransfer and dnd AWT tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 61c7351: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code
  • 7610862: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
  • 1087e3b: 8306996: Open source Swing MenuItem related tests
  • bcb1f86: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken
  • f655ccd: 8304760: Add 2 Microsoft TLS roots
  • e55bea4: 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs
  • e7bac42: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
  • 093f02a: 8305975: Add TWCA Global Root CA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2023
@mlbridge
Copy link

mlbridge bot commented May 16, 2023

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 17, 2023
@openjdk
Copy link

openjdk bot commented May 17, 2023

@Rudometov
Your change (at version 169f034) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 17, 2023

Going to push as commit e3e7722.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 39f944b: 8307130: Open source few Swing JMenu tests
  • 61c7351: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code
  • 7610862: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
  • 1087e3b: 8306996: Open source Swing MenuItem related tests
  • bcb1f86: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken
  • f655ccd: 8304760: Add 2 Microsoft TLS roots
  • e55bea4: 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs
  • e7bac42: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
  • 093f02a: 8305975: Add TWCA Global Root CA

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2023
@openjdk openjdk bot closed this May 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 17, 2023
@openjdk
Copy link

openjdk bot commented May 17, 2023

@phohensee @Rudometov Pushed as commit e3e7722.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants