Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8227060: Optimize safepoint cleanup subtask order #1377

Closed
wants to merge 3 commits into from
Closed

8227060: Optimize safepoint cleanup subtask order #1377

wants to merge 3 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 19, 2023 •
edited by openjdk bot

Unclean backport to improve the safepoint cleanup times. Provides the grounds for the ultimate improvement in safepoint cleanup (JDK-8306738). The backport is not clean, because there are copyright years conflicts, the rename of AbstractGangTask to WorkerTask is missing, WorkGang -> WorkerThreads rename is missing, JavaThread::cast cleanup is missing.

Additional testing:

  • Ad-hoc benchmarks
  • Linux x86_64 fastdebug tier1 tier2 tier3

The safepoint cleanup times are slightly better on small tests, and there seem to be no regressions.
plot

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8227060: Optimize safepoint cleanup subtask order

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1377/head:pull/1377
$ git checkout pull/1377

Update a local copy of the PR:
$ git checkout pull/1377
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1377

View PR using the GUI difftool:
$ git pr show -t 1377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1377.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 96a542feb2064dba155ebf05311752995d164038 8227060: Optimize safepoint cleanup subtask order May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 19, 2023
@shipilev shipilev marked this pull request as ready for review May 19, 2023 14:40
@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2023
@mlbridge
Copy link

mlbridge bot commented May 19, 2023 •
edited

Webrevs

@openjdk openjdk bot mentioned this pull request May 19, 2023
Closed
5 tasks
phohensee
phohensee approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented May 19, 2023 •
edited

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8227060: Optimize safepoint cleanup subtask order

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
  • 9c0afc5: 8306752: Open source several container and component AWT tests
  • 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
  • b5d3772: 8306683: Open source several clipboard and color AWT tests
  • 09e6880: 8306652: Open source AWT MenuItem related tests
  • 18ec008: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
  • 536e133: 8306850: Open source AWT Modal related tests
  • 7277a75: 8306072: Open source several AWT MouseInfo related tests
  • 40526a7: 8307080: Open source some more JComboBox jtreg tests
  • ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/879f4c591b82494157f3013041695a4cc4f1996b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 19, 2023
@shipilev
Copy link
Member Author

Lgtm.

Thank you! I marked the issue for maintainer approval.

@shipilev
Copy link
Member Author

Lgtm.

While looking at it again, I noticed that I missed the optimization from the original change: 1dbff5e -- please re-review. Re-doing testing again, expecting no problems.

@shipilev
Copy link
Member Author

Lgtm.

While looking at it again, I noticed that I missed the optimization from the original change: 1dbff5e -- please re-review. Re-doing testing again, expecting no problems.

@phohensee, if you can review again, please? Thanks!

phohensee
phohensee approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that too! Ltgm, again.

@shipilev
Copy link
Member Author

Testing is clean, reviews are good, push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2023

Going to push as commit 464a32b.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
  • 9c0afc5: 8306752: Open source several container and component AWT tests
  • 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
  • b5d3772: 8306683: Open source several clipboard and color AWT tests
  • 09e6880: 8306652: Open source AWT MenuItem related tests
  • 18ec008: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
  • 536e133: 8306850: Open source AWT Modal related tests
  • 7277a75: 8306072: Open source several AWT MouseInfo related tests
  • 40526a7: 8307080: Open source some more JComboBox jtreg tests
  • ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/879f4c591b82494157f3013041695a4cc4f1996b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2023
@openjdk openjdk bot closed this May 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@shipilev Pushed as commit 464a32b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8227060-optimize-safepoint-cleanup-order branch July 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
2 participants
@shipilev @phohensee