-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308884: [17u/11u] Backout JDK-8297951 #1402
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
/summary This reverts commit 08e30d0 |
@jerboaa Setting summary to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
@jerboaa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! |
/integrate |
Going to push as commit a93cf5f.
Your commit was automatically rebased without conflicts. |
Please review this backout patch for JDK-8297951 which got included in 17.0.7 release and causes crashes. The patch is the result of
git revert 08e30d0b371b7a0dc498b87ff509cde98a8e077c
.Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1402/head:pull/1402
$ git checkout pull/1402
Update a local copy of the PR:
$ git checkout pull/1402
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1402/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1402
View PR using the GUI difftool:
$ git pr show -t 1402
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1402.diff
Webrev
Link to Webrev Comment