Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308884: [17u/11u] Backout JDK-8297951 #1402

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented May 25, 2023

Please review this backout patch for JDK-8297951 which got included in 17.0.7 release and causes crashes. The patch is the result of git revert 08e30d0b371b7a0dc498b87ff509cde98a8e077c.

Testing:

  • Reproducer from JDK-8307683 crashes the VM before the patch and the crash is gone after.
  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1402/head:pull/1402
$ git checkout pull/1402

Update a local copy of the PR:
$ git checkout pull/1402
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1402/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1402

View PR using the GUI difftool:
$ git pr show -t 1402

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1402.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2023

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jerboaa
Copy link
Contributor Author

jerboaa commented May 25, 2023

/summary This reverts commit 08e30d0

@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@jerboaa Setting summary to This reverts commit 08e30d0b371b7a0dc498b87ff509cde98a8e077c

@mlbridge
Copy link

mlbridge bot commented May 25, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented May 29, 2023

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308884: [17u/11u] Backout JDK-8297951

This reverts commit 08e30d0b371b7a0dc498b87ff509cde98a8e077c

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • b10ac57: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64
  • 1684377: 8303809: Dispose context in SPNEGO NegotiatorImpl
  • 6919ff2: 8301119: Support for GB18030-2022
  • 3d32a20: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
  • 6287df0: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
  • 6803da9: 8301661: Enhance os::pd_print_cpu_info on macOS and Windows
  • 0d2cc35: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • 5bf1b9a: 8283520: JFR: Memory leak in dcmd_arena
  • c581886: 8307128: Open source some drag and drop tests 4
  • 14779b1: 8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 29, 2023
@jerboaa
Copy link
Contributor Author

jerboaa commented May 30, 2023

Thanks for the review!

@jerboaa
Copy link
Contributor Author

jerboaa commented May 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2023

Going to push as commit a93cf5f.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 8f65a6d: 8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable
  • 109cc49: 8308880: [17u] micro bench ZoneStrings missed in backport of 8278434
  • de8ec1d: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
  • ff0ee6d: 8301637: ThreadLocalRandom.current().doubles().parallel() contention
  • bc78e07: 8293295: Add type check asserts to java_lang_ref_Reference accessors
  • 213d0db: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
  • b10ac57: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64
  • 1684377: 8303809: Dispose context in SPNEGO NegotiatorImpl
  • 6919ff2: 8301119: Support for GB18030-2022
  • 3d32a20: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/57d0a7f1b69214bd2de951c9907fe1321a66f3b8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2023
@openjdk openjdk bot closed this May 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

@jerboaa Pushed as commit a93cf5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants