Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293492: ShenandoahControlThread missing from hs-err log and thread dump #1405

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 26, 2023

Unclean backport to improve Shenandoah and keep implementation on sync.

The backport is not clean, because JDK-8268855 is not present in JDK 17.

Additional testing:

  • Linux x86_64 fastdebug hotspot_gc_shenandoah

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293492: ShenandoahControlThread missing from hs-err log and thread dump

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1405/head:pull/1405
$ git checkout pull/1405

Update a local copy of the PR:
$ git checkout pull/1405
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1405

View PR using the GUI difftool:
$ git pr show -t 1405

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1405.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 85ec1f8d020cf2a9d7dfcc9ed75e43f0cd61c1f2 8293492: ShenandoahControlThread missing from hs-err log and thread dump May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 26, 2023
@mlbridge
Copy link

mlbridge bot commented May 26, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293492: ShenandoahControlThread missing from hs-err log and thread dump

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 1684377: 8303809: Dispose context in SPNEGO NegotiatorImpl
  • 6919ff2: 8301119: Support for GB18030-2022
  • 3d32a20: 8286331: jni_GetStringUTFChars() uses wrong heap allocator

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 26, 2023
@shipilev
Copy link
Member Author

Review is here. Testing is clean. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2023

Going to push as commit de8ec1d.
Since your change was applied there have been 7 commits pushed to the master branch:

  • ff0ee6d: 8301637: ThreadLocalRandom.current().doubles().parallel() contention
  • bc78e07: 8293295: Add type check asserts to java_lang_ref_Reference accessors
  • 213d0db: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
  • b10ac57: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64
  • 1684377: 8303809: Dispose context in SPNEGO NegotiatorImpl
  • 6919ff2: 8301119: Support for GB18030-2022
  • 3d32a20: 8286331: jni_GetStringUTFChars() uses wrong heap allocator

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2023
@openjdk openjdk bot closed this May 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

@shipilev Pushed as commit de8ec1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants