Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309138: Fix container tests for jdks with symlinked conf dir #1417

Closed

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Jun 7, 2023

This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests.

Testing:
tier1: OK
containers and jdk/internal/platform: OK


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309138: Fix container tests for jdks with symlinked conf dir (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1417/head:pull/1417
$ git checkout pull/1417

Update a local copy of the PR:
$ git checkout pull/1417
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1417

View PR using the GUI difftool:
$ git pr show -t 1417

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1417.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2023

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ec55539534d43629c1a47407a8e2e94913034a71 8309138: Fix container tests for jdks with symlinked conf dir Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@zzambers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309138: Fix container tests for jdks with symlinked conf dir

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ef86ea2: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2023

Webrevs

@zzambers
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 12, 2023
@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@zzambers
Your change (at version ef897a0) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Jun 14, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

Going to push as commit 01ac9cb.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 6991372: 8305995: Footprint regression from JDK-8224957
  • 2570e72: 8308300: enhance exceptions in MappedMemoryUtils.c
  • ebb9a36: 8309297: Adjust ShenandoahHeap print_heap_regions_on
  • 8ac9c57: Merge
  • 0f531da: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates
  • 22a548b: 8307395: Add missing STS to Shenandoah
  • 12d08f0: 8308156: VerifyCACerts.java misses blank in error output
  • e898048: 8307572: AArch64: Vector registers are clobbered by some macroassemblers
  • f80be82: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()
  • b6a5d20: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/ac9c69663d4b146e258752da530e2ec0fee180fa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2023
@openjdk openjdk bot closed this Jun 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@jerboaa @zzambers Pushed as commit 01ac9cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants