Skip to content

8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Jun 15, 2023

Testing:

  • hotspot_gc_shenandoah
  • dacapo
  • extremem
  • specjbb2015
  • hyperalloc

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1448/head:pull/1448
$ git checkout pull/1448

Update a local copy of the PR:
$ git checkout pull/1448
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1448

View PR using the GUI difftool:
$ git pr show -t 1448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1448.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d39f09c6cdc875b44147b4e84e496b6abf93996 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 832707b: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • dfe3555: 8303215: Make thread stacks not use huge pages
  • 52fb263: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
  • 00b8f5d: 8308643: Incorrect value of 'used' jvmstat counter
  • e0c9643: 8306281: function isWsl() returns false on WSL2
  • 8dae82c: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error
  • bd0e479: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 7c97df2: 8309862: Unsafe list operations in JfrStringPool
  • 19acd07: 8307301: Update HarfBuzz to 7.2.0
  • f8e0f6e: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • ... and 21 more: https://git.openjdk.org/jdk17u-dev/compare/249ddf4c42a271c58624890fb13d7afbce710e07...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 15, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

@shipilev
Copy link
Member

I think it needs JDK-8287227 as the follow-up too, see linked issues in the JIRA.

@earthling-amzn
Copy link
Contributor Author

Should JDK-8287227 come in a separate PR? or should I cherry-pick that change into this PR?

@shipilev
Copy link
Member

Should JDK-8287227 come in a separate PR? or should I cherry-pick that change into this PR?

What you did is right: a dependent PR. Get the push approval for both PRs, and then integrate them one by one.

@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@earthling-amzn
Your change (at version 028a821) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit b8a65e0.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 832707b: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • dfe3555: 8303215: Make thread stacks not use huge pages
  • 52fb263: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
  • 00b8f5d: 8308643: Incorrect value of 'used' jvmstat counter
  • e0c9643: 8306281: function isWsl() returns false on WSL2
  • 8dae82c: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error
  • bd0e479: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 7c97df2: 8309862: Unsafe list operations in JfrStringPool
  • 19acd07: 8307301: Update HarfBuzz to 7.2.0
  • f8e0f6e: 8307604: gcc12 based Alpine build broken build after JDK-8307301
  • ... and 21 more: https://git.openjdk.org/jdk17u-dev/compare/249ddf4c42a271c58624890fb13d7afbce710e07...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@shipilev @earthling-amzn Pushed as commit b8a65e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants