Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics #1449

Closed

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jun 15, 2023

Testing:

  • hotspot_gc_shenandoah
  • dacapo
  • extremem
  • specjbb2015
  • hyperalloc

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1449/head:pull/1449
$ git checkout pull/1449

Update a local copy of the PR:
$ git checkout pull/1449
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1449

View PR using the GUI difftool:
$ git pr show -t 1449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1449.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3675f4c2afd10b5042948fc79e62caee5f3874ce 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 6c81bf5: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32
  • c6f6db2: 8295657: SA: Allow larger object alignments
  • 55c0eaa: 8272654: Mark word accesses should not use Access API
  • 7697ab4: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
  • 852c26c: 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517
  • 5fc07b5: 8305815: Update Libpng to 1.6.39
  • 9dd23ff: 8292315: Tests should not rely on specific JAR file names (hotspot)
  • f21f9a4: 8292316: Tests should not rely on specific JAR file names (jpackage)
  • 01369a6: 8285756: clean up use of bad arguments for @clean in langtools tests
  • 4bbead6: 8286620: Create regression test for verifying setMargin() of JRadioButton
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/f9a60759b13f242c45bef8506e25ffea3e972247...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 15, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jun 16, 2023

I appreciate your thorough testing.

@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@earthling-amzn
Your change (at version bb6be40) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

Going to push as commit 249ddf4.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 5a4e374: 8309959: JFR: Display N/A for missing data amount
  • 6c81bf5: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32
  • c6f6db2: 8295657: SA: Allow larger object alignments
  • 55c0eaa: 8272654: Mark word accesses should not use Access API
  • 7697ab4: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
  • 852c26c: 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517
  • 5fc07b5: 8305815: Update Libpng to 1.6.39
  • 9dd23ff: 8292315: Tests should not rely on specific JAR file names (hotspot)
  • f21f9a4: 8292316: Tests should not rely on specific JAR file names (jpackage)
  • 01369a6: 8285756: clean up use of bad arguments for @clean in langtools tests
  • ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/f9a60759b13f242c45bef8506e25ffea3e972247...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2023
@openjdk openjdk bot closed this Jun 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@shipilev @earthling-amzn Pushed as commit 249ddf4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants