New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. #1479
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/integrate |
@earthling-amzn This pull request has not yet been marked as ready for integration. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout jdk17u-dev-8287227
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@earthling-amzn |
/sponsor |
Going to push as commit 5021a07. |
@shipilev @earthling-amzn Pushed as commit 5021a07. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This clean backport depends on #1448
Testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1479/head:pull/1479
$ git checkout pull/1479
Update a local copy of the PR:
$ git checkout pull/1479
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1479/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1479
View PR using the GUI difftool:
$ git pr show -t 1479
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1479.diff
Webrev
Link to Webrev Comment