Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. #1479

Closed

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jun 20, 2023

This clean backport depends on #1448

Testing:

  • hotspot_gc_shenandoah
  • dacapo
  • extremem
  • specjbb2015
  • hyperalloc

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1479/head:pull/1479
$ git checkout pull/1479

Update a local copy of the PR:
$ git checkout pull/1479
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1479/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1479

View PR using the GUI difftool:
$ git pr show -t 1479

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1479.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2023

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 210a06a287521a554316a9052bd9fdf616c7b884 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2023

Webrevs

@earthling-amzn earthling-amzn changed the base branch from master to pr/1448 June 20, 2023 18:26
@openjdk openjdk bot added the clean label Jun 20, 2023
@earthling-amzn
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@earthling-amzn This pull request has not yet been marked as ready for integration.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1448 to master June 23, 2023 17:59
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk17u-dev-8287227
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Jun 23, 2023
@openjdk openjdk bot added the clean label Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 23, 2023
@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@earthling-amzn
Your change (at version 2a0ddd2) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 24, 2023

Going to push as commit 5021a07.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2023
@openjdk openjdk bot closed this Jun 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 24, 2023
@openjdk
Copy link

openjdk bot commented Jun 24, 2023

@shipilev @earthling-amzn Pushed as commit 5021a07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants