Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306881: Update FreeType to 2.13.0 #1504

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 28, 2023

Clean backport of JDK-8306881 plus workaround for build warning with Xcode 11.3 (2nd commit).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1504/head:pull/1504
$ git checkout pull/1504

Update a local copy of the PR:
$ git checkout pull/1504
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1504

View PR using the GUI difftool:
$ git pr show -t 1504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1504.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 723582c524c62ee73f7984a53b046f8832b23a7f 8306881: Update FreeType to 2.13.0 Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 28, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

1st commit causes build warning with Xcode 11.3 (see #1500).
I'd prefer to use that one. However, if anybody needs to build with old Xcode for whatever reason ...

@TheRealMDoerr
Copy link
Contributor Author

Closing in favor of #1500.

@TheRealMDoerr TheRealMDoerr deleted the 8306881_FreeType_2.13.0 branch July 20, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant