Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306575: Clean up and open source four Dialog related tests #1513

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 29, 2023

I backport this for parity with 17.0.9-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306575: Clean up and open source four Dialog related tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1513/head:pull/1513
$ git checkout pull/1513

Update a local copy of the PR:
$ git checkout pull/1513
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1513

View PR using the GUI difftool:
$ git pr show -t 1513

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1513.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d696aea9e1cefca97a760c017a5fde545facaa9 8306575: Clean up and open source four Dialog related tests Jun 29, 2023
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306575: Clean up and open source four Dialog related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 136 new commits pushed to the master branch:

  • 4dd316b: 8307156: native_thread not protected by TLH
  • 295cf44: 8290464: Optimize ResourceArea zapping on ResourceMark release
  • b8a0a22: 8295812: Skip the "half float" support in LittleCMS during the build
  • 3d53b27: 8308152: PropertyDescriptor should work with overridden generic getter method
  • 95b4ddc: 8310126: C1: Missing receiver null check in Reference::get intrinsic
  • 4fd0ee5: 8305425: Thread.isAlive0 doesn't need to call into the VM
  • 8204dfa: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • d27e56e: 8305950: Have -XshowSettings option display tzdata version
  • 9b89523: 8298974: Add ftcolor.c to imported freetype sources
  • 5021a07: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled.
  • ... and 126 more: https://git.openjdk.org/jdk17u-dev/compare/6cc377db3ed16f37df2ec6bd85f9586e4090feb3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2023

Going to push as commit 2f31b3f.
Since your change was applied there have been 148 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2023
@openjdk openjdk bot closed this Jul 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2023
@openjdk
Copy link

openjdk bot commented Jul 3, 2023

@GoeLin Pushed as commit 2f31b3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant