8268582: javadoc throws NPE with --ignore-source-errors option

[apavlyutkin]

I'd like to backport JDK-8268582 to jdk17u-dev

The patch fixes javadoc NPE when using the --ignore-source-errors option with an non-existing type.

Original patch applied cleanly

Verification: javadoc --ignore-source-errors ./Test.java where Test.java has the following content

import invalid.example.OtherClass;

public class Test<T> extends OtherClass<T> {

}

Regression: langtools_javadoc (20.04/amd64)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8268582: javadoc throws NPE with --ignore-source-errors option

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/152/head:pull/152
$ git checkout pull/152

Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 152

View PR using the GUI difftool:
$ git pr show -t 152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/152.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268582: javadoc throws NPE with --ignore-source-errors option

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 879f4c5: 8297154: Improve safepoint cleanup logging
• 2913a8d: 8306753: Open source several container AWT tests
• 406d6ba: 8307378: Allow collectors to provide specific values for GC notifications' actions
• 36c364d: 8284331: Add sanity check for signal handler modification warning.
• 4a0f0f4: 8276058: Some swing test fails on specific CI macos system
• f2e837f: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (5cb220b8)
• 00: Full (55345442)

[bridgekeeper]

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mollyibot]

I have encountered the same issue, is there any solution to avoid this NPE? for example by passing some extra flags?

[shipilev]

@apavlyutkin: You also need to reopen this PR, and probably remerge it from master to get clean testing.

[GoeLin]

Hi @apavlyutkin
please enable pre-submit tests and merge head to restart the testing.

[openjdk]

⚠️ @apavlyutkin This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[apavlyutkin]

fixed

[apavlyutkin]

/integrate

[openjdk]

@apavlyutkin
Your change (at version 5cb220b) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

@yan-too @apavlyutkin Unable to acquire the integration lock; aborting sponsored integration. The error has been logged and will be investigated.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 17b3640.
Since your change was applied there have been 10 commits pushed to the master branch:

• 39a6b55: 8287854: Dangling reference in ClassVerifier::verify_class
• 9cb0120: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
• 32fda32: 8296343: CPVE thrown on missing content-length in OCSP response
• 6b362e4: 8261495: Shenandoah: reconsider update references memory ordering
• 879f4c5: 8297154: Improve safepoint cleanup logging
• 2913a8d: 8306753: Open source several container AWT tests
• 406d6ba: 8307378: Allow collectors to provide specific values for GC notifications' actions
• 36c364d: 8284331: Add sanity check for signal handler modification warning.
• 4a0f0f4: 8276058: Some swing test fails on specific CI macos system
• f2e837f: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @apavlyutkin Pushed as commit 17b3640.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.