Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong #1520

Conversation

schmelter-sap
Copy link
Contributor

@schmelter-sap schmelter-sap commented Jun 30, 2023

Hi all,

This pull request contains a backport of commit 728157fa from the openjdk/jdk repository.

The commit being backported was authored by Ralf Schmelter on 12 Jul 2022 and was reviewed by Thomas Schatzl, Markus Grönlund, Thomas Stuefe and Erik Gahlin.

It just fixes the metadata of an JFR event.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1520/head:pull/1520
$ git checkout pull/1520

Update a local copy of the PR:
$ git checkout pull/1520
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1520

View PR using the GUI difftool:
$ git pr show -t 1520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1520.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2023

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 728157fa03913991088f6bb257a8bc16706792a9 8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@schmelter-sap This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 99c7ade: 8301074: Replace NULL with nullptr in share/opto/
  • 1472676: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads
  • c5649ac: 8297887: Update Siphash
  • c3b8ea3: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
  • 4dd316b: 8307156: native_thread not protected by TLH
  • 295cf44: 8290464: Optimize ResourceArea zapping on ResourceMark release
  • b8a0a22: 8295812: Skip the "half float" support in LittleCMS during the build
  • 3d53b27: 8308152: PropertyDescriptor should work with overridden generic getter method
  • 95b4ddc: 8310126: C1: Missing receiver null check in Reference::get intrinsic
  • 4fd0ee5: 8305425: Thread.isAlive0 doesn't need to call into the VM
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/9b895233315c21920edc7ba48915afdc0a5c220a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2023

@schmelter-sap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@schmelter-sap
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 31, 2023

Going to push as commit ba17497.
Since your change was applied there have been 133 commits pushed to the master branch:

  • aaf47b3: 8307526: [JFR] Better handling of tampered JFR repository
  • 2940973: 8301367: Add exception handler method to the BaseLdapServer
  • 7d29233: 8299617: CurrencySymbols.properties is missing the copyright notice
  • 61442ce: 8296384: [TESTBUG] sun/security/provider/SecureRandom/AbstractDrbg/SpecTest.java intermittently timeout
  • 89b4429: 8293177: Verify version numbers in legal files
  • 9ed5671: 8289510: Improve test coverage for XPath Axes: namespace
  • 2a70aaa: 8270331: [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java
  • 90202ef: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out
  • c54ecfb: 8296796: Provide clean, platform-agnostic interface to C-heap trimming
  • 67c5150: 8311285: report some fontconfig related environment variables in hs_err file
  • ... and 123 more: https://git.openjdk.org/jdk17u-dev/compare/9b895233315c21920edc7ba48915afdc0a5c220a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 31, 2023
@openjdk openjdk bot closed this Jul 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@schmelter-sap Pushed as commit ba17497.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant