Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304725: AsyncGetCallTrace can cause SIGBUS on M1 #1554

Closed
wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Jul 6, 2023

Hi!

I'd like to backport these changes to get around the WX status uncertainty in AsyncGetCallTrace. The function doesn't use ThreadWXEnable like other VM signal handlers, and writing to the CompiledMethod field results in SIGBUS.

Clean backport. Tested with hostpot tier1 and manually enabled jtreg/serviceability/AsyncGetCallTrace


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304725: AsyncGetCallTrace can cause SIGBUS on M1 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1554/head:pull/1554
$ git checkout pull/1554

Update a local copy of the PR:
$ git checkout pull/1554
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1554

View PR using the GUI difftool:
$ git pr show -t 1554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1554.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2023

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d8af7a6014055295355a1242db6c2872299c6398 8304725: AsyncGetCallTrace can cause SIGBUS on M1 Jul 6, 2023
@openjdk
Copy link

openjdk bot commented Jul 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 6, 2023

@snazarkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304725: AsyncGetCallTrace can cause SIGBUS on M1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 195 new commits pushed to the master branch:

  • 43f14e4: 8311249: Remove unused MemAllocator::obj_memory_range
  • 8a9162f: 8268852: AsyncLogWriter should not overide is_Named_thread()
  • 688a823: 8307299: Move more DnD tests to open
  • 93bfec2: 8307083: Open source some drag and drop tests 3
  • b3cf45a: 8306812: Open source several AWT Miscellaneous tests
  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • b8cf161: 8307078: Opensource and clean up five more AWT Focus related tests
  • 8d49a8a: 8306638: Open source some AWT tests related to datatransfer and Toolkit
  • b7c1456: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper
  • e28a5ea: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • ... and 185 more: https://git.openjdk.org/jdk17u-dev/compare/d4467a72e6c1f124b07b0c1e2b753d65d6a41ff1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 6, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2023

Webrevs

@snazarkin
Copy link
Contributor Author

Got stamp

@snazarkin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2023

Going to push as commit c2e274e.
Since your change was applied there have been 199 commits pushed to the master branch:

  • 3b4df97: 6176679: Application freezes when copying an animated gif image to the system clipboard
  • 2bc77e3: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor
  • 50399e3: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
  • fc08b73: 8307348: Parallelize heap walk for ObjectCount(AfterGC) JFR event collection
  • 43f14e4: 8311249: Remove unused MemAllocator::obj_memory_range
  • 8a9162f: 8268852: AsyncLogWriter should not overide is_Named_thread()
  • 688a823: 8307299: Move more DnD tests to open
  • 93bfec2: 8307083: Open source some drag and drop tests 3
  • b3cf45a: 8306812: Open source several AWT Miscellaneous tests
  • e8e87c4: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • ... and 189 more: https://git.openjdk.org/jdk17u-dev/compare/d4467a72e6c1f124b07b0c1e2b753d65d6a41ff1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2023
@openjdk openjdk bot closed this Jul 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2023
@openjdk
Copy link

openjdk bot commented Jul 7, 2023

@snazarkin Pushed as commit c2e274e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant