8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes

[snazarkin]

Hi!

This is follow up for #1557. The backport is not clean since JDK-8285675 was skipped intentionally.

Tested with gtest:all on RPi3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes (Bug - P4)
• JDK-8284997: arm32 build crashes since JDK-8283326 (Bug - P3)
• JDK-8285675: Temporary fix for arm32 SafeFetch (Bug - P4)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer) ⚠️ Review applies to 404b6992

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1577/head:pull/1577
$ git checkout pull/1577

Update a local copy of the PR:
$ git checkout pull/1577
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1577

View PR using the GUI difftool:
$ git pr show -t 1577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1577.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into pr/1557 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (8080a0fa)
• 01: Full - Incremental (404b6992)
• 00: Full (404b6992)

[tstuefe]

Hi!

This is follow up for #1557. The backport is not clean since JDK-8285675 was skipped intentionally.

Tested with gtest:all on RPi3

Progress

* [ ]  Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))

* [x]  Change must not contain extraneous whitespace

* [x]  Commit message must refer to an issue

Integration blocker

warning Dependency #1557 must be integrated first

Issues

* [JDK-8288719](https://bugs.openjdk.org/browse/JDK-8288719): [arm32] SafeFetch32 thumb interleaving causes random crashes (**Bug** - P4)

* [JDK-8284997](https://bugs.openjdk.org/browse/JDK-8284997): arm32 build crashes since JDK-8283326 (**Bug** - P3)

Reviewing

Using git
Using Skara CLI tools
Using diff file

Webrev

Link to Webrev Comment

Please use links to JBS, not to Azul-internal bug trackers (also I'm too lazy to lookup 8285675 manually :).

[snazarkin]

Oops! Updated the link to JBS

[tstuefe]

Okay.

Note that the test needs to be executed on a machine where gcc uses mthumb by default, IIRC.

OTOH the patch is so basic that this is fine even without testing.

[GoeLin]

Can you please do / isuue add JDK-8285675 as this subsumes that change.
And mention so in a fix request comment on 8285675?

[snazarkin]

/issue add 8285675

[openjdk]

@snazarkin
Adding additional issue to issue list: 8285675: Temporary fix for arm32 SafeFetch.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8284997
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@snazarkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes
8284997: arm32 build crashes since JDK-8283326
8285675: Temporary fix for arm32 SafeFetch

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[snazarkin]

Got the push approval.

/integrate

[openjdk]

Going to push as commit 8c1a5bc.

[openjdk]

@snazarkin Pushed as commit 8c1a5bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.