8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if

[benty-amzn]

Backport is nearly clean, because https://bugs.openjdk.org/browse/JDK-8275201 has not been backported.
Only context lines in src/hotspot/share/opto/subtypenode.cpp differ, the assert itself is unmodified.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if (Bug - P3)

Reviewers

• Volker Simonis (@simonis - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1580/head:pull/1580
$ git checkout pull/1580

Update a local copy of the PR:
$ git checkout pull/1580
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1580

View PR using the GUI difftool:
$ git pr show -t 1580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1580.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• c2543ea: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• 34da7e2: 8275415: Prepare Leak Profiler for Lilliput
• eb7900a: 8306881: Update FreeType to 2.13.0
• 95a89ed: 8286623: Bundle zlib by default with JDK on macos aarch64
• b40b1ca: 8295894: Remove SECOM certificate that is expiring in September 2023
• 901e879: 8312029: Add CriticalNative tests to ProblemList for 8312028
• fade19e: 8308803: Improve java/util/UUID/UUIDTest.java
• 4b8c6b8: 8302736: Major performance regression in Math.log on aarch64
• b5f27f9: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout
• b640436: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
• ... and 29 more: https://git.openjdk.org/jdk17u-dev/compare/9f3c0957868f1203e7341695838fde4e325025e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@simonis) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (84257575)

[simonis]

Looks good.

Thanks for downporting!

[GoeLin]

What is wrong with the GHA tests?
Did you run the test?

[benty-amzn]

The failed test gc/metaspace/TestMetaspacePerfCounters.java#id3 on mac in the previous iteration appears to have been flaky or an infra issue. It passed on retry, and the new failure seems to be an infrastructure issue in riscv64. As mentioned on https://bugs.openjdk.org/browse/JDK-8303279 I've tested this change locally and it passes both the included test and jtregs tier 1 through 4.

[benty-amzn]

/integrate

[openjdk]

@benty-amzn
Your change (at version 8425757) is now ready to be sponsored by a Committer.

[simonis]

/sponsor

[openjdk]

Going to push as commit baf2841.
Since your change was applied there have been 39 commits pushed to the master branch:

• c2543ea: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• 34da7e2: 8275415: Prepare Leak Profiler for Lilliput
• eb7900a: 8306881: Update FreeType to 2.13.0
• 95a89ed: 8286623: Bundle zlib by default with JDK on macos aarch64
• b40b1ca: 8295894: Remove SECOM certificate that is expiring in September 2023
• 901e879: 8312029: Add CriticalNative tests to ProblemList for 8312028
• fade19e: 8308803: Improve java/util/UUID/UUIDTest.java
• 4b8c6b8: 8302736: Major performance regression in Math.log on aarch64
• b5f27f9: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout
• b640436: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
• ... and 29 more: https://git.openjdk.org/jdk17u-dev/compare/9f3c0957868f1203e7341695838fde4e325025e4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@simonis @benty-amzn Pushed as commit baf2841.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.