Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272998: ImageIO.read() throws incorrect exception type #1582

Closed
wants to merge 1 commit into from

Conversation

kspeeyu
Copy link
Contributor

@kspeeyu kspeeyu commented Jul 13, 2023

Backport for [JDK-8272998]
ImageIO.read() throws incorrect exception type
New tests all pass
tier1 tested with GHA
tier2 tested on linux


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8272998 needs maintainer approval

Issue

  • JDK-8272998: ImageIO.read() throws incorrect exception type (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1582/head:pull/1582
$ git checkout pull/1582

Update a local copy of the PR:
$ git checkout pull/1582
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1582/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1582

View PR using the GUI difftool:
$ git pr show -t 1582

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1582.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

👋 Welcome back kspeeyu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6ad6b1c454cbc41de5a401aecda910d668c71e39 8272998: ImageIO.read() throws incorrect exception type Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@kspeeyu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272998: ImageIO.read() throws incorrect exception type

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 272 new commits pushed to the master branch:

  • d7e22e8: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 056ba2d: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 3f29f1e: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 6a0dfaf: 8308223: failure handler missed jcmd.vm.info command
  • aaa6962: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"
  • c00d445: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • 18fd988: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation
  • adef8e4: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled
  • 9f384e7: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
  • 8314149: 8315606: Open source few swing text/html tests
  • ... and 262 more: https://git.openjdk.org/jdk17u-dev/compare/9f3c0957868f1203e7341695838fde4e325025e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2023

@kspeeyu This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member

@kspeeyu, you need to request the push approval for 17u-dev by setting jdk17u-fix-request label in the bug and providing the "Fix Request" comment.

@shipilev
Copy link
Member

Please also rebase to current master to get the actual testing.

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

⚠️ @kspeeyu This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed ready Pull request is ready to be integrated labels Sep 7, 2023
@GoeLin
Copy link
Member

GoeLin commented Sep 11, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@GoeLin
8272998: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 11, 2023
@kspeeyu
Copy link
Contributor Author

kspeeyu commented Oct 9, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@kspeeyu
Your change (at version ac707f3) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

Going to push as commit 66baa03.
Since your change was applied there have been 273 commits pushed to the master branch:

  • a393f25: 8303607: SunMSCAPI provider leaks memory and keys
  • d7e22e8: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 056ba2d: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 3f29f1e: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 6a0dfaf: 8308223: failure handler missed jcmd.vm.info command
  • aaa6962: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"
  • c00d445: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • 18fd988: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation
  • adef8e4: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled
  • 9f384e7: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
  • ... and 263 more: https://git.openjdk.org/jdk17u-dev/compare/9f3c0957868f1203e7341695838fde4e325025e4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2023
@openjdk openjdk bot closed this Oct 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@shipilev @kspeeyu Pushed as commit 66baa03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants