New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272998: ImageIO.read() throws incorrect exception type #1582
Conversation
👋 Welcome back kspeeyu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@kspeeyu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 272 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@kspeeyu This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@kspeeyu, you need to request the push approval for 17u-dev by setting |
Please also rebase to current master to get the actual testing. |
/approve yes |
@GoeLin |
/integrate |
/sponsor |
Going to push as commit 66baa03.
Your commit was automatically rebased without conflicts. |
Backport for [JDK-8272998]
ImageIO.read() throws incorrect exception type
New tests all pass
tier1 tested with GHA
tier2 tested on linux
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1582/head:pull/1582
$ git checkout pull/1582
Update a local copy of the PR:
$ git checkout pull/1582
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1582/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1582
View PR using the GUI difftool:
$ git pr show -t 1582
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1582.diff
Webrev
Link to Webrev Comment