New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8281717: Cover logout method for several LoginModule #1606
Conversation
/issue add JDK-8224090 |
/issue remove JDK-8224090 |
/issue add JDK-8284090 |
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin |
@GoeLin |
@GoeLin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
GHA failure: known riskv issue |
/integrate |
Going to push as commit 4f4e042.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.9-oracle.
I am including JDK-8284090 as without the test does not compile.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1606/head:pull/1606
$ git checkout pull/1606
Update a local copy of the PR:
$ git checkout pull/1606
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1606/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1606
View PR using the GUI difftool:
$ git pr show -t 1606
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1606.diff
Webrev
Link to Webrev Comment