Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281717: Cover logout method for several LoginModule #1606

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 20, 2023

I backport this for parity with 17.0.9-oracle.

I am including JDK-8284090 as without the test does not compile.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8281717: Cover logout method for several LoginModule (Enhancement - P3)
  • JDK-8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1606/head:pull/1606
$ git checkout pull/1606

Update a local copy of the PR:
$ git checkout pull/1606
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1606

View PR using the GUI difftool:
$ git pr show -t 1606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1606.diff

Webrev

Link to Webrev Comment

@GoeLin
Copy link
Member Author

GoeLin commented Jul 20, 2023

/issue add JDK-8224090

@GoeLin
Copy link
Member Author

GoeLin commented Jul 20, 2023

/issue remove JDK-8224090

@GoeLin
Copy link
Member Author

GoeLin commented Jul 20, 2023

/issue add JDK-8284090

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fbb8ca55a80683a730179303b31c5c150bcca8a9 8281717: Cover logout method for several LoginModule Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@GoeLin
Adding additional issue to issue list: 8224090: [PPC64] Fix SLP patterns for filling an array with double float literals.

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@GoeLin
Removing additional issue from issue list: 8224090.

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@GoeLin
Adding additional issue to issue list: 8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile.

@mlbridge
Copy link

mlbridge bot commented Jul 20, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281717: Cover logout method for several LoginModule
8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jul 21, 2023

GHA failure: known riskv issue

@GoeLin
Copy link
Member Author

GoeLin commented Jul 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2023

Going to push as commit 4f4e042.
Since your change was applied there have been 5 commits pushed to the master branch:

  • baf2841: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • c2543ea: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
  • 34da7e2: 8275415: Prepare Leak Profiler for Lilliput
  • eb7900a: 8306881: Update FreeType to 2.13.0
  • 95a89ed: 8286623: Bundle zlib by default with JDK on macos aarch64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 23, 2023
@openjdk openjdk bot closed this Jul 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2023
@openjdk
Copy link

openjdk bot commented Jul 23, 2023

@GoeLin Pushed as commit 4f4e042.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8281717 branch July 23, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants