8313678: SymbolTable can leak Symbols during cleanup

[olivergillespie]

Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678.

Not totally clean:

• places where 17 uses NULL versus nullptr in tip, trivial fix
• symbolTable uses Symbol** in 17 instead of Symbol*, also easy fix
• dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it
• finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313678: SymbolTable can leak Symbols during cleanup (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1674/head:pull/1674
$ git checkout pull/1674

Update a local copy of the PR:
$ git checkout pull/1674
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1674

View PR using the GUI difftool:
$ git pr show -t 1674

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1674.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (134adab9)

[phohensee]

Please file a 21u backport PR to go with this one.

Have you done testing other than GHA?

[olivergillespie]

I tested that the new test fails without the patch, and passes with it. Nothing else.

Here's the 21 backport openjdk/jdk21u#73

[phohensee]

Looks good. Please tag the JBS issue.

[openjdk]

@olivergillespie This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313678: SymbolTable can leak Symbols during cleanup

Reviewed-by: phh, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• d82de1c: 8314517: some tests fail in case ipv6 is disabled on the machine
• 1d65a31: 8284772: GHA: Use GCC Major Version Dependencies Only
• 47ed2e5: 8311033: [macos] PrinterJob does not take into account Sides attribute
• 4c123ac: 8295737: macOS: Print content cut off when width > height with portrait orientation
• 7286bb8: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows
• fdc4130: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
• 3c426c7: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction
• f667b35: 8293114: JVM should trim the native heap
• 1421540: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0
• d9985d0: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
• ... and 24 more: https://git.openjdk.org/jdk17u-dev/compare/ca0f148681114b64ba0b40ea77b89a5e9bc68657...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

This looks fine.

Could you please check that the test addition is sensitive to this bug? I.e. locally revert every hunk except the test one, would the test fail then?

[olivergillespie]

Thanks.

Could you please check that the test addition is sensitive to this bug? I.e. locally revert every hunk except the test one, would the test fail then?

Yes, confirmed.

[olivergillespie]

/integrate

[openjdk]

@olivergillespie
Your change (at version 134adab) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit a75e5de.
Since your change was applied there have been 38 commits pushed to the master branch:

• c91fb3f: 8313874: JNI NewWeakGlobalRef throws exception for null arg
• 7ea65a0: Merge
• 0f29caa: 8313765: Invalid CEN header (invalid zip64 extra data field size)
• b31f232: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1
• d82de1c: 8314517: some tests fail in case ipv6 is disabled on the machine
• 1d65a31: 8284772: GHA: Use GCC Major Version Dependencies Only
• 47ed2e5: 8311033: [macos] PrinterJob does not take into account Sides attribute
• 4c123ac: 8295737: macOS: Print content cut off when width > height with portrait orientation
• 7286bb8: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows
• fdc4130: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
• ... and 28 more: https://git.openjdk.org/jdk17u-dev/compare/ca0f148681114b64ba0b40ea77b89a5e9bc68657...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @olivergillespie Pushed as commit a75e5de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.