8285516: clearPassword should be called in a finally try block

[chadrako]

JDK-8285516

Clean backport

clearPassword should be called in a finally try block

---

Progress

• JDK-8285516 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8285516: clearPassword should be called in a finally try block (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1722/head:pull/1722
$ git checkout pull/1722

Update a local copy of the PR:
$ git checkout pull/1722
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1722/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1722

View PR using the GUI difftool:
$ git pr show -t 1722

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1722.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chadrako! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@chadrako This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285516: clearPassword should be called in a finally try block

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 45b6bca: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
• 4e9b6da: 8309032: jpackage does not work for module projects unless --module-path is specified
• a5a3505: 8315549: CITime misreports code/total nmethod sizes
• f8f4943: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
• be34f0b: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
• bb2fcb8: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
• 6b192d3: 8299677: Formatter.format might take a long time to format an integer or floating-point
• caaf942: Merge
• dc00ae4: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
• a44f8b0: 8314960: Add Certigna Root CA - 2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (4dc5c19c)

[openjdk]

⚠️ @chadrako This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Hi @chadrako,
next time please add some content to your Fix request comment in the JBS issue: mention reason, risk, testing etc.

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8285516: The approval request has been approved.

[chadrako]

/integrate

[openjdk]

@chadrako
Your change (at version 4dc5c19) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 4ac28fc.
Since your change was applied there have been 11 commits pushed to the master branch:

• 444f829: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint
• 45b6bca: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
• 4e9b6da: 8309032: jpackage does not work for module projects unless --module-path is specified
• a5a3505: 8315549: CITime misreports code/total nmethod sizes
• f8f4943: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
• be34f0b: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
• bb2fcb8: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
• 6b192d3: 8299677: Formatter.format might take a long time to format an integer or floating-point
• caaf942: Merge
• dc00ae4: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/75e14419d29c1dc98bd040490e93ae8f6eee4e43...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @chadrako Pushed as commit 4ac28fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.