Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293861: G1: Disable preventive GCs by default #1758

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Sep 20, 2023

Not a clean backport due to neighboring changes in the same file. Patch is simple and manual fixes are trivial.

As mentioned in the JBS issue, preventive GCs has had issues on JDK 17. TrinoDB is impacted and recommends disabling preventive GCs in trinodb/trino#15380. We have seen internal applications that are affected by this issue as well.

GHA are full green. Locally run tier1 tests are all green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8293861 needs maintainer approval

Issue

  • JDK-8293861: G1: Disable preventive GCs by default (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1758/head:pull/1758
$ git checkout pull/1758

Update a local copy of the PR:
$ git checkout pull/1758
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1758

View PR using the GUI difftool:
$ git pr show -t 1758

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1758.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2023

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d7c1a7635d3437b91fba358e8682b4a56a65d826 8293861: G1: Disable preventive GCs by default Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

⚠️ @caojoshua This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2023

Webrevs

@openjdk openjdk bot added the approval label Sep 26, 2023
@caojoshua caojoshua closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
1 participant