Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298867: Basics.java fails with SSL handshake exception #1800

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 27, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • JDK-8298867 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298867: Basics.java fails with SSL handshake exception (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1800/head:pull/1800
$ git checkout pull/1800

Update a local copy of the PR:
$ git checkout pull/1800
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1800/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1800

View PR using the GUI difftool:
$ git pr show -t 1800

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1800.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 06f9374e0c59fa666e6f120749d9170f65fadc4f 8298867: Basics.java fails with SSL handshake exception Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2023

Webrevs

@openjdk openjdk bot added the approval label Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298867: Basics.java fails with SSL handshake exception

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 9404b2b: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • 486a468: 8307732: build-test-lib is broken
  • 0ce7d86: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • 4ecf818: 8276054: JMH benchmarks for Fences
  • 8961594: 8300997: Add curl support to createJMHBundle.sh
  • e7fc89d: 8313322: RISC-V: implement MD5 intrinsic
  • 64be3f0: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 28, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit 9fce30a.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 1ce8f3e: 8293156: Dcmd VM.classloaders fails to print the full hierarchy
  • 7e58a42: 8283670: gtest os.release_multi_mappings_vm is still racy
  • 9404b2b: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • 486a468: 8307732: build-test-lib is broken
  • 0ce7d86: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • 4ecf818: 8276054: JMH benchmarks for Fences
  • 8961594: 8300997: Add curl support to createJMHBundle.sh
  • e7fc89d: 8313322: RISC-V: implement MD5 intrinsic
  • 64be3f0: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@GoeLin Pushed as commit 9fce30a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant