Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301570: Test runtime/jni/nativeStack/ needs to detach the native thread #1881

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Oct 15, 2023

  • Backport of JDK-8301570
  • Test succeeded in local dev box

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301570 needs maintainer approval

Issue

  • JDK-8301570: Test runtime/jni/nativeStack/ needs to detach the native thread (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1881/head:pull/1881
$ git checkout pull/1881

Update a local copy of the PR:
$ git checkout pull/1881
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1881

View PR using the GUI difftool:
$ git pr show -t 1881

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1881.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2023

👋 Welcome back amosshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d269ebbad2286b57802a075091b0cc32110dfcc7 8301570: Test runtime/jni/nativeStack/ needs to detach the native thread Oct 15, 2023
@openjdk
Copy link

openjdk bot commented Oct 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 15, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 15, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Oct 16, 2023

/approval request "Backporting for parity with 17.0.8-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass.”

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi
8301570: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

⚠️ @amosshi the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8301570
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301570: Test  runtime/jni/nativeStack/ needs to detach the native thread

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 18d61ea: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
  • 7c26fd8: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 16, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Oct 16, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi
Your change (at version a18aebc) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit 7c3e0d4.
Since your change was applied there have been 7 commits pushed to the master branch:

  • f7fb52b: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg
  • 436f148: 8296275: Write a test to verify setAccelerator method of JMenuItem
  • b07d8c2: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • 052a05d: 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose
  • 3637245: 8317772: NMT: Make peak values available in release builds
  • 18d61ea: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
  • 7c26fd8: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@GoeLin @amosshi Pushed as commit 7c3e0d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8301570 branch October 17, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants