-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10> #1888
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue JDK-8296821 |
@GoeLin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 9914915.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.10-oracle.
The files have been moved in 17 by backport "8303588: [JVMCI] make JVMCI source directories conform with standard layout". After fixing the patch file to point to the new locations, the patch applies clean.
I include follow-up bug fix JDK-8296821. This also applied clean, except for the ProblemList change.
Problemlisting of the test was not backported.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1888/head:pull/1888
$ git checkout pull/1888
Update a local copy of the PR:
$ git checkout pull/1888
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1888/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1888
View PR using the GUI difftool:
$ git pr show -t 1888
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1888.diff
Webrev
Link to Webrev Comment