New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292458: Atomic operations on scoped enums don't build with clang #1948
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/approval request Clean backport to improve native atomics support. This does not fix any currently observed bugs, but it should provide more safety for backports that would use scoped enums and clang. It also makes subsequent backports cleaner. There is no bugtail recorded for this improvement, after more than a year in mainline. Light testing passes. |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2f042a4. |
Clean backport to improve native atomics support. This does not fix any currently observed bugs, but it should provide more safety for backports that would use scoped enums and clang. It also makes subsequent backports cleaner. There is no bugtail recorded for this improvement, after more than a year in mainline.
Additional testing:
tier1
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1948/head:pull/1948
$ git checkout pull/1948
Update a local copy of the PR:
$ git checkout pull/1948
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1948/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1948
View PR using the GUI difftool:
$ git pr show -t 1948
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1948.diff
Webrev
Link to Webrev Comment