Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292458: Atomic operations on scoped enums don't build with clang #1948

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 6, 2023

Clean backport to improve native atomics support. This does not fix any currently observed bugs, but it should provide more safety for backports that would use scoped enums and clang. It also makes subsequent backports cleaner. There is no bugtail recorded for this improvement, after more than a year in mainline.

Additional testing:

  • MacOS AArch64 server fastdebug, tier1

Progress

  • Change must not contain extraneous whitespace
  • JDK-8292458 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8292458: Atomic operations on scoped enums don't build with clang (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1948/head:pull/1948
$ git checkout pull/1948

Update a local copy of the PR:
$ git checkout pull/1948
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1948/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1948

View PR using the GUI difftool:
$ git pr show -t 1948

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1948.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f85411f24a0cf55f8718aadd2297d95feb95564b 8292458: Atomic operations on scoped enums don't build with clang Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 6, 2023

/approval request Clean backport to improve native atomics support. This does not fix any currently observed bugs, but it should provide more safety for backports that would use scoped enums and clang. It also makes subsequent backports cleaner. There is no bugtail recorded for this improvement, after more than a year in mainline. Light testing passes.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@shipilev
8292458: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292458: Atomic operations on scoped enums don't build with clang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval ready Pull request is ready to be integrated labels Nov 9, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2023

Going to push as commit 2f042a4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2023
@openjdk openjdk bot closed this Dec 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 11, 2023

@shipilev Pushed as commit 2f042a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant