Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317374: Add Let's Encrypt ISRG Root X2 #1950

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 7, 2023

I backport this for parity with 17.0.10-oracle.

I had to adapt the location of the cert and checksum in the test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317374 needs maintainer approval

Issue

  • JDK-8317374: Add Let's Encrypt ISRG Root X2 (Enhancement - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1950/head:pull/1950
$ git checkout pull/1950

Update a local copy of the PR:
$ git checkout pull/1950
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1950/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1950

View PR using the GUI difftool:
$ git pr show -t 1950

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1950.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e6f46a43268808d0cbbb3bb93c73aa8e4cbfad83 8317374: Add Let's Encrypt ISRG Root X2 Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 7, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2023

Webrevs

@openjdk openjdk bot added approval and removed approval labels Nov 7, 2023
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting!

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317374: Add Let's Encrypt ISRG Root X2

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 1240b34: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • 5cb86e3: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Nov 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

Going to push as commit 8b9a72e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • a4fe7ac: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • 1240b34: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • 5cb86e3: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2023
@openjdk openjdk bot closed this Nov 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@GoeLin Pushed as commit 8b9a72e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8317374 branch November 9, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants