Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8054572: [macosx] JComboBox paints the border incorrectly #2020

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 5, 2023

A fix useful for 17 on mac.

Resolved the copyright, will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8054572 needs maintainer approval

Issue

  • JDK-8054572: [macosx] JComboBox paints the border incorrectly (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2020/head:pull/2020
$ git checkout pull/2020

Update a local copy of the PR:
$ git checkout pull/2020
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2020

View PR using the GUI difftool:
$ git pr show -t 2020

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2020.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8082c24a0df3f4861ea391266bdfe6cdd1a77bab 8054572: [macosx] JComboBox paints the border incorrectly Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 6, 2023

/clean

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8054572: [macosx] JComboBox paints the border incorrectly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 5217b07: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
  • 4d716cc: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 16f319a: 8307990: jspawnhelper must close its writing side of a pipe before reading from it
  • 0bc91f6: 8313643: Update HarfBuzz to 8.2.2
  • 450c201: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
  • 5025a97: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • be72703: 8301306: java/net/httpclient/* fail with -Xcomp
  • f8f733d: Merge
  • b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 7, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit 644a430.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 5217b07: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
  • 4d716cc: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 16f319a: 8307990: jspawnhelper must close its writing side of a pipe before reading from it
  • 0bc91f6: 8313643: Update HarfBuzz to 8.2.2
  • 450c201: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
  • 5025a97: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • be72703: 8301306: java/net/httpclient/* fail with -Xcomp
  • f8f733d: Merge
  • b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2023
@GoeLin GoeLin deleted the goetz_backport_8054572 branch December 7, 2023 08:26
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@GoeLin Pushed as commit 644a430.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant