Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272853: improve JavadocTester.runTests #2111

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 8, 2024

I backport this for parity with 17.0.11-oracle.

Resolved one import, probably recognized clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8272853 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272853: improve JavadocTester.runTests (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2111/head:pull/2111
$ git checkout pull/2111

Update a local copy of the PR:
$ git checkout pull/2111
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2111

View PR using the GUI difftool:
$ git pr show -t 2111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2111.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b0028a459c7e99b5e4090cc19127f6347fe220ba 8272853: improve JavadocTester.runTests Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 9, 2024

Thanks for the review!

@openjdk openjdk bot added the approval label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272853: improve `JavadocTester.runTests`

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • f194105: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • ea6fc21: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 262b83c: 8322583: RISC-V: Enable fast class initialization checks
  • 0927587: 6928542: Chinese characters in RTF are not decoded
  • 26b5597: 8322725: (tz) Update Timezone Data to 2023d
  • 002270c: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • bfd23ae: 8322772: Clean up code after JDK-8322417

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 10, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 11, 2024

Going to push as commit 5e81941.
Since your change was applied there have been 7 commits pushed to the master branch:

  • f194105: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • ea6fc21: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 262b83c: 8322583: RISC-V: Enable fast class initialization checks
  • 0927587: 6928542: Chinese characters in RTF are not decoded
  • 26b5597: 8322725: (tz) Update Timezone Data to 2023d
  • 002270c: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • bfd23ae: 8322772: Clean up code after JDK-8322417

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 11, 2024
@openjdk openjdk bot closed this Jan 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2024
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@GoeLin Pushed as commit 5e81941.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8272853 branch January 11, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants