Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323008: filter out harmful -std* flags added by autoconf from CXX #2137

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 18, 2024

GHA actions are failing because of this issue.

Resolved two Copyrights, will mark clean if not recognized as such anyways.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323008 needs maintainer approval

Issue

  • JDK-8323008: filter out harmful -std* flags added by autoconf from CXX (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2137/head:pull/2137
$ git checkout pull/2137

Update a local copy of the PR:
$ git checkout pull/2137
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2137

View PR using the GUI difftool:
$ git pr show -t 2137

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2137.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d 8323008: filter out harmful -std* flags added by autoconf from CXX Jan 18, 2024
@openjdk
Copy link

openjdk bot commented Jan 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 18, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 18, 2024
@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323008: filter out harmful -std* flags added by autoconf from CXX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 18, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 18, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

Going to push as commit a632e30.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 18, 2024
@openjdk openjdk bot closed this Jan 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2024
@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@GoeLin Pushed as commit a632e30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8323008 branch January 18, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant