Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test #2194

Closed
wants to merge 3 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 6, 2024

The option "-XX:LoopUnrollLimit=0" results in no unrolling and consequently no vectorization opportunities in the test code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8291809 needs maintainer approval

Issue

  • JDK-8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2194/head:pull/2194
$ git checkout pull/2194

Update a local copy of the PR:
$ git checkout pull/2194
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2194

View PR using the GUI difftool:
$ git pr show -t 2194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2194.diff

Webrev

Link to Webrev Comment

The option "-XX:LoopUnrollLimit=0" results in no unrolling and consequently no vectorization opportunities in the test code.

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sendaoYan
Copy link
Member Author

sendaoYan commented Feb 6, 2024

TestSSE2IntVect.java test fail with -XX:LoopUnrollLimit=0 before this PR:

java.lang.RuntimeException: Unexpected AndV number: expected 0 >= 3
        at jdk.test.lib.Asserts.fail(Asserts.java:594)
        at jdk.test.lib.Asserts.assertGreaterThanOrEqual(Asserts.java:288)
        at jdk.test.lib.Asserts.assertGTE(Asserts.java:259)
        at compiler.c2.cr7200264.TestDriver.verifyVectorizationNumber(TestDriver.java:63)
        at compiler.c2.cr7200264.TestDriver.run(TestDriver.java:43)
        at compiler.c2.cr7200264.TestSSE2IntVect.main(TestSSE2IntVect.java:47)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
        at java.base/java.lang.Thread.run(Thread.java:840)

@openjdk openjdk bot changed the title Backport 4da28b40f04acc355d86d44cb8d9fa0c5c7829bd 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 6, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 6, 2024

Webrevs

@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 6, 2024
@sendaoYan
Copy link
Member Author

TestIntVect.java test pass after this PR:

image

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 6, 2024
@sendaoYan
Copy link
Member Author

This PR only change the testcase, the testcase change has been verified. Please review this PR.

@sendaoYan sendaoYan marked this pull request as draft March 6, 2024 13:08
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 6, 2024
@sendaoYan sendaoYan closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant