8286740: JFR: Active Setting event emitted incorrectly

[richardstartin]

jtreg_jfr passed here

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8286740 needs maintainer approval

Issue

• JDK-8286740: JFR: Active Setting event emitted incorrectly (Bug - P3 - Approved)

Reviewers

• Jaroslav Bachorik (@jbachorik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2210/head:pull/2210
$ git checkout pull/2210

Update a local copy of the PR:
$ git checkout pull/2210
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2210

View PR using the GUI difftool:
$ git pr show -t 2210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2210.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back richardstartin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (c88231ac)

[jbachorik]

I cross-checked the diff against the original fix and the only minor difference is MetadataRepository.java where configuration.getEventControl() was changed to handler.getEventControl().

LGTM

[openjdk]

⚠️ @richardstartin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[richardstartin]

/approval 8286740 request

[openjdk]

@richardstartin
8286740: The approval request has been created successfully.

[GoeLin]

Fix request comment missing, see https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

[GoeLin]

@richardstartin How did you test this?
I would like to delay this to the July update, can you please label again after 27.2.?

[richardstartin]

@richardstartin How did you test this? I would like to delay this to the July update, can you please label again after 27.2.?

As mentioned above, we ran the linked JFR jtreg tests, which pass.

[openjdk]

@richardstartin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286740: JFR: Active Setting event emitted incorrectly

Reviewed-by: jbachorik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

• c9b0307: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used
• 0b20589: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
• 27cf2f4: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
• 6488725: 8324598: use mem_unit when working with sysinfo memory and swap related information
• 02ef1c7: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
• 09ebd1c: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
• 49c260d: 8315898: Open source swing JMenu tests
• b632518: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
• 3433fdb: 8314283: Support for NSS tests on aarch64 platforms
• 0606e5a: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
• ... and 67 more: https://git.openjdk.org/jdk17u-dev/compare/a234b7c0edd2caf482089a32a63ae79a423e3687...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jbachorik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jbachorik]

/integrate

[openjdk]

@jbachorik Only the author (@richardstartin) is allowed to issue the integrate command.

[richardstartin]

/integrate

[openjdk]

@richardstartin
Your change (at version c88231a) is now ready to be sponsored by a Committer.

[jbachorik]

/sponsor

[openjdk]

Going to push as commit 4b9ab0d.
Since your change was applied there have been 77 commits pushed to the master branch:

• c9b0307: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used
• 0b20589: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
• 27cf2f4: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
• 6488725: 8324598: use mem_unit when working with sysinfo memory and swap related information
• 02ef1c7: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
• 09ebd1c: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
• 49c260d: 8315898: Open source swing JMenu tests
• b632518: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
• 3433fdb: 8314283: Support for NSS tests on aarch64 platforms
• 0606e5a: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
• ... and 67 more: https://git.openjdk.org/jdk17u-dev/compare/a234b7c0edd2caf482089a32a63ae79a423e3687...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jbachorik @richardstartin Pushed as commit 4b9ab0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.