New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used #2321
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@SoniaZaldana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Hi Sonia, |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout my-backport-8326591
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
SAP nightlies passed on
|
Hi all,
This PR contains a backport of 43c6f0b5880899b797fab2f851bd35be1c342439.
Patch is not clean. Test won't build in 17 because it can't find
import jdk.internal.util.OperatingSystem
.This class was introduced in 21 as part of JDK-8303485.
I've worked around that by removing the dependency to that utility function and checking the operating system with
test/lib/jdk/test/lib/Platform.java
.Testing:
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2321/head:pull/2321
$ git checkout pull/2321
Update a local copy of the PR:
$ git checkout pull/2321
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2321/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2321
View PR using the GUI difftool:
$ git pr show -t 2321
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2321.diff
Webrev
Link to Webrev Comment