Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264322: Generate CDS archive when creating custom JDK image #2371

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 5, 2024


Progress

  • Change requires CSR request JDK-8330019 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8264322 needs maintainer approval

Issues

  • JDK-8264322: Generate CDS archive when creating custom JDK image (Enhancement - P4 - Approved)
  • JDK-8330019: Add jlink --generate-cds-archive plugin to generate CDS archive in the resulting image (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2371/head:pull/2371
$ git checkout pull/2371

Update a local copy of the PR:
$ git checkout pull/2371
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2371

View PR using the GUI difftool:
$ git pr show -t 2371

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2371.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264322: Generate CDS archive when creating custom JDK image

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

  • 54e0120: 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+
  • 3f5e536: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
  • bcc83cd: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • b13cb2f: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
  • 3324133: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • 10b427d: 8329570: G1: Excessive is_obj_dead_cond calls in verification
  • f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
  • 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
  • aa9c12b: 8315609: Open source few more swing text/html tests
  • 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
  • ... and 50 more: https://git.openjdk.org/jdk17u-dev/compare/e789a6735fd40ac69b7720c2e16e27fcf1b500ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f608e81ad8309a001b8a92563a93b8adee1ce2b8 8264322: Generate CDS archive when creating custom JDK image Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 5, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed csr Pull request needs approved CSR before integration labels Apr 15, 2024
@MBaesken
Copy link
Member Author

lots of upload/download/infra errors in the GHAs.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 26, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

Going to push as commit aea8e4a.
Since your change was applied there have been 68 commits pushed to the master branch:

  • b7c7ea0: 8328194: Add a test to check default rendering engine
  • 032e87a: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
  • 4cec951: 8315889: Open source several Swing HTMLDocument related tests
  • 52d1f0c: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 9682314: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
  • 71630eb: 8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs
  • e51f176: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • 9b2f521: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols
  • 54e0120: 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+
  • 3f5e536: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
  • ... and 58 more: https://git.openjdk.org/jdk17u-dev/compare/e789a6735fd40ac69b7720c2e16e27fcf1b500ed...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2024
@openjdk openjdk bot closed this Apr 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@MBaesken Pushed as commit aea8e4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant