Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297695: Fix typos in test/langtools files #2383

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 9, 2024

I backport this for parity with 17.0.12-oracle.

Resolved JavadocTester because of extra line at end of file.
Will mark clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8297695 needs maintainer approval

Issue

  • JDK-8297695: Fix typos in test/langtools files (Task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2383/head:pull/2383
$ git checkout pull/2383

Update a local copy of the PR:
$ git checkout pull/2383
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2383

View PR using the GUI difftool:
$ git pr show -t 2383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2383.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297695: Fix typos in test/langtools files

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 85e3f1a: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • c758755: 8315834: Open source several Swing JSpinner related tests
  • fc01ffe: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • c430b11: 8305645: System Tray icons get corrupted when Windows primary monitor changes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e10778accef05bb17eea20d589086b50e366dc4d 8297695: Fix typos in test/langtools files Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 9, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 10, 2024

/clean

@openjdk openjdk bot added the clean label Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

Going to push as commit 00a1fe9.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 1ae82df: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
  • 85e3f1a: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • c758755: 8315834: Open source several Swing JSpinner related tests
  • fc01ffe: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • c430b11: 8305645: System Tray icons get corrupted when Windows primary monitor changes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2024
@openjdk openjdk bot closed this Apr 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@GoeLin Pushed as commit 00a1fe9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8297695 branch April 11, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant